This fixes issue #73 #82

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@NathanaelA
Contributor

NathanaelA commented Jul 13, 2012

If you do a .text("") or .text(" ") the words = null, so the next line the words.length is invalid.

@pietervandereems

This comment has been minimized.

Show comment Hide comment
@pietervandereems

pietervandereems Oct 31, 2012

This fix has the draw back that the original string is not added to the pdf.
Since the regexp will also return null on a string like "???" I think it's better to use [text] as default value on the regexp.
Added a pull request with that fix.

This fix has the draw back that the original string is not added to the pdf.
Since the regexp will also return null on a string like "???" I think it's better to use [text] as default value on the regexp.
Added a pull request with that fix.

@NathanaelA

This comment has been minimized.

Show comment Hide comment
@NathanaelA

NathanaelA Aug 14, 2013

Contributor

This has been fixed in a more recent version so this pull request is no longer valid.

Contributor

NathanaelA commented Aug 14, 2013

This has been fixed in a more recent version so this pull request is no longer valid.

@NathanaelA NathanaelA closed this Aug 14, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment