-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match runner overview #4
Comments
Do you see it as a grid listing + "add new" interface?
Sounds like one screen with two identical input sections for files 1 and 2, and the submit button that sends two separate POST requests.
A display-only grid of "/inspection_runs"?
I understand that this is our main interface, that now opens with the button "New" and the grid, will have an input form as described:
Is this a grid of run matches with the "launch" button and job status? Why not add "run" + status to the screen 4.?
Is it used in the UI? |
Yes please!
I was putting it above for reference, not for frontend implementation - the users don't need to see this for now. However you need the ID of the 2 inspection runs (run_a, run_b) in order to create the
Precisely!
I think you can use the |
I've set up the endpoints that will allow the user to upload files and launch a match between the two files, and then output the results of the match to a CSV. I'm going to discuss the endpoints here so we can work together on tying it all up.
Before you read this - please review #2 to refresh yourself on the user flow (we are dropping item 5 for now).
I imagine you'll have questions so let me know and I'll update here and in Slack so we're on the same page.
Short version:
POST
to/pipeline/
- make a new pipelinePOST
to/raw_file/
- uploads files - do this 2 times with additional form data (discussed below)POST
to/run_match/
- make a new run match with all of its related dataPOST
to/matchrunner/<runmatch_id>/
to launch a data match on the filesGET
to/matchrunner/<runmatch_id>/export
to return the data as CSV text, which you'll then need to package into a file for the user to download.More detail:
Pipeline
POST
to/pipeline/
with aname
parameter, thats it.RawFile
POST
request to/raw_file/
now requires additional data attributes, sent as a multi-part form:file
- file upload,source
text input,data_mapping_id
- dropdown (endpoint/feature_maps/
),pipeline_id
- dropdown,run_date
- text-input,sheet_name
- text input,source
- text inputInspectionRun
id (gets created automatically) in the response from the post. I can make it available elsewhere if you need but you could also traverse backwards fromGET
/inspection_runs/
which listsraw_file_id
'sInspectionRun
RunMatch
references the inspection runs directly, not the raw files).RunMatch
RawFiles
, it will generate 2 correspondingInspectionRun
's that we can use to generate a RunMatch.POST
to RunMatch requires just aname
,run_a
(earlierInspectionRun
),run_b
(laterInspectionRun
), and apipeline_id
RunMatchConf
record is created in the background with my standard defaults, but we should allow the user to tweak the launch of the matcherMatchRunner
POST
/match_runner/<run_match_id>
to launch the match for the runGET
/run_match/1
endpointMatchExporter
GET
/matchrunner/<run_match_id>/export
export CSV
button for this in two places - on the matching interface and on therun_match
listings.The text was updated successfully, but these errors were encountered: