Fix: Make root action self-contained for external usage #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change from calling sub-actions with relative paths to running npm commands directly - Fixes error when action is used externally: 'Can't find action.yml under ./analyze' - Root action now contains full implementation (Node.js setup, npm ci, analyze, charts) - Sub-actions (analyze/ and charts/) remain available for modular usage via direct reference This follows the standard GitHub Actions pattern where: - Root action is self-contained and can be used externally - Sub-actions can still be called independently as: - devops-actions/github-copilot-pr-analysis/analyze@version - devops-actions/github-copilot-pr-analysis/charts@version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using the action externally (e.g.,
devops-actions/github-copilot-pr-analysis@v0.0.1), the root action failed with:This happened because the root
action.ymlwas trying to call sub-actions using relative paths (./analyzeand./charts), which don't work when the action is consumed externally.Solution
Updated the root
action.ymlto run the npm commands directly instead of calling sub-actions via relative paths. This follows the standard GitHub Actions pattern where:Changes
analyze/andcharts/) remain unchanged and usable independentlyUsage Patterns
All three usage patterns now work correctly:
1. Full Action (Analysis + Charts)
2. Analysis Only
3. Charts Only
Testing
Tested with rajbos/rajbos#77 which was failing with the error above.
Related