New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image compression to pull requests #8273
Comments
This workflow seems to take a really long time to run (it's at >13m right now and it's not done yet in my first test). It seems like with GitHub Actions we can set an action to run only on specific branches; maybe what we could do is create a naming standard and manually push PR's from that branch every now and again to optimize all the images, something like:
So for example, if I want to run an image optimization, I would run |
Oh! You can run actions on a schedule: https://help.github.com/en/articles/workflow-syntax-for-github-actions#onschedule
If we wanted it to run every day against
I think the schedule is the best way to do it. Thoughts, @adrianmoisey and @bridgetkromhout ? |
(The full action takes 21 minutes to run, so it's not something we want to run on all PR's) |
Hmm. Doesn't look like it completes for us: https://github.com/devopsdays/devopsdays-web/pull/8274/checks?check_run_id=222210418#step:4:7320
|
I logged an issue on calibreapp/image-actions about this :) calibreapp/image-actions#13 |
Doesn't look like this issue on the actions side is going to be handled, so we might need a new solution. |
Suggested by @mrbusche, we should add the image-actions GitHub action to automatically perform compression on images in PR's.
The text was updated successfully, but these errors were encountered: