Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encrypts connection before passing creds #43

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

00willo
Copy link

@00willo 00willo commented Feb 27, 2019

Ensure appropriate flags are set on ldap3.Connection object based on the following:

  • use SSL if ldaps is specified in url config option, ie ldaps on port 636
  • explicitly disables ssl, but enables TLS creation before the user bind passes credentials if any tls config is defined. ie ldap on port 389+start_tls

@00willo
Copy link
Author

00willo commented Mar 20, 2019

Updated PR to also test with python3.7.

Looks like the Travis build failed on the first commit due to a transient dependency issue, which is now resolved.

@00willo
Copy link
Author

00willo commented Mar 28, 2019

@fschulze Do you need anything else added or changed in this PR before it can be merged?

@fschulze
Copy link
Contributor

@00willo time to look at it. I hope to get to it next week. Thanks!

@fschulze
Copy link
Contributor

Work on devpi-ldap was very low priority for a while, so I only got to look at this now.

This PR looks very useful, but the code base has changed a bit in the meantime. Would you still be interested in rebasing and updating this PR? If so, it would be nice to have some tests for the added conditions in the connection setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants