From d07380cdd9abdfc81a7ec8217cc836bfccf129f3 Mon Sep 17 00:00:00 2001 From: Bertrand THOMAS Date: Fri, 20 Mar 2026 22:12:46 +0100 Subject: [PATCH 1/5] Update github reusable workflow ref --- .github/workflows/ci.yaml | 8 ++++---- .github/workflows/pkg.yaml | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 9486ad0..58c74c0 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -37,13 +37,13 @@ jobs: markup-lint: name: Markup - uses: devpro/github-workflow-parts/.github/workflows/reusable-markup-lint.yml@5a5d1cd0a00c94ebec1e096e9086f2b88cc5eb96 + uses: devpro/github-workflow-parts/.github/workflows/reusable-markup-lint.yml@a6cc8b1b98ab0783e0b1b95d8d6c81fa2be07e6a code-quality: name: Code needs: git-check if: needs.git-check.outputs.app_changed == 'true' || (github.event_name == 'workflow_dispatch' && inputs.run-code-quality) - uses: devpro/github-workflow-parts/.github/workflows/reusable-dotnet-quality.yml@5a5d1cd0a00c94ebec1e096e9086f2b88cc5eb96 + uses: devpro/github-workflow-parts/.github/workflows/reusable-dotnet-quality.yml@a6cc8b1b98ab0783e0b1b95d8d6c81fa2be07e6a with: custom-commands: | ./scripts/mongodb-install.sh @@ -62,7 +62,7 @@ jobs: sonar-organization: ${{ vars.SONAR_ORG }} sonar-project-key: ${{ vars.SONAR_PROJECT_KEY }} sonar-project-name: Keeptrack - workflow-parts-version: 5a5d1cd0a00c94ebec1e096e9086f2b88cc5eb96 + workflow-parts-version: a6cc8b1b98ab0783e0b1b95d8d6c81fa2be07e6a secrets: fossa-api-key: ${{ secrets.FOSSA_API_KEY }} sonar-token: ${{ secrets.SONAR_TOKEN }} @@ -90,7 +90,7 @@ jobs: - name: "Web Api" image-name: "keeptrack-webapi" image-definition: "src/WebApi/Dockerfile" - uses: devpro/github-workflow-parts/.github/workflows/reusable-container-scan.yml@5a5d1cd0a00c94ebec1e096e9086f2b88cc5eb96 + uses: devpro/github-workflow-parts/.github/workflows/reusable-container-scan.yml@a6cc8b1b98ab0783e0b1b95d8d6c81fa2be07e6a with: image-definition: ${{ matrix.image-definition }} image-name: ${{ matrix.image-name }} diff --git a/.github/workflows/pkg.yaml b/.github/workflows/pkg.yaml index 1717233..a007f69 100644 --- a/.github/workflows/pkg.yaml +++ b/.github/workflows/pkg.yaml @@ -28,7 +28,7 @@ jobs: permissions: id-token: write contents: read - uses: devpro/github-workflow-parts/.github/workflows/reusable-container-publication.yml@5a5d1cd0a00c94ebec1e096e9086f2b88cc5eb96 + uses: devpro/github-workflow-parts/.github/workflows/reusable-container-publication.yml@a6cc8b1b98ab0783e0b1b95d8d6c81fa2be07e6a with: create-latest: ${{ github.ref_name == 'main' }} image-definition: ${{ matrix.image-definition }} From 0743531069da09f3534c463ec8427209451e004b Mon Sep 17 00:00:00 2001 From: Bertrand THOMAS Date: Fri, 20 Mar 2026 22:13:01 +0100 Subject: [PATCH 2/5] Update Azure DevOps CI pipeline --- .azure/pipelines/ci.yml | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/.azure/pipelines/ci.yml b/.azure/pipelines/ci.yml index 7c0b28d..02c4fd2 100644 --- a/.azure/pipelines/ci.yml +++ b/.azure/pipelines/ci.yml @@ -50,7 +50,7 @@ stages: script: > dotnet test --configuration $(BuildConfiguration) - -- --filter-query "/[Category=UnitTests]" + -- --filter-query "/[(Category=UnitTests)]" env: AllowedOrigins__0: "5207" Features__IsScalarEnabled: true @@ -107,10 +107,7 @@ stages: inputs: command: "test" projects: "$(TestProjects)" - arguments: | - --configuration $(BuildConfiguration) - --report-xunit-trx --coverage --coverage-output-format cobertura - -- --filter-query "/[(Category=UnitTests)|(Mode=Readonly)]" + arguments: '--configuration $(BuildConfiguration) --report-xunit-trx --coverage --coverage-output-format cobertura -- --filter-query "/[(Category=UnitTests)|(Mode=Readonly)]"' env: AllowedOrigins__0: "5207" Features__IsScalarEnabled: true From 1e3e653a6747568d072f7be69b42452b633eaf8d Mon Sep 17 00:00:00 2001 From: Bertrand THOMAS Date: Fri, 20 Mar 2026 22:13:14 +0100 Subject: [PATCH 3/5] Increase yaml line length to 200 --- .yamllint.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.yamllint.yaml b/.yamllint.yaml index ebf4450..4a88842 100644 --- a/.yamllint.yaml +++ b/.yamllint.yaml @@ -6,7 +6,7 @@ rules: document-start: disable line-length: level: warning - max: 170 + max: 200 truthy: disable brackets: max-spaces-inside: 1 From 5493ecddb5d247f1b7da126bd5dfaec13a787076 Mon Sep 17 00:00:00 2001 From: Bertrand THOMAS Date: Fri, 20 Mar 2026 22:24:19 +0100 Subject: [PATCH 4/5] Fix typo in git check --- .github/workflows/reusable-git-check.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/reusable-git-check.yml b/.github/workflows/reusable-git-check.yml index 6fb3d92..1993f7e 100644 --- a/.github/workflows/reusable-git-check.yml +++ b/.github/workflows/reusable-git-check.yml @@ -69,7 +69,7 @@ jobs: echo "No relevant changes" echo "app_changed=false" >> $GITHUB_OUTPUT else - echo "Changes detected in src/test" + echo "Changes detected in $APP_FOLDERS" git diff --name-status "$BEFORE" ${{ github.sha }} -- $APP_FOLDERS echo "app_changed=true" >> $GITHUB_OUTPUT fi @@ -87,4 +87,4 @@ jobs: echo "Major.Minor: $MAJOR_MINOR" echo "version_major_minor=$MAJOR_MINOR" >> "$GITHUB_OUTPUT" env: - APP_FOLDERS: ${{ inputs.app_folders }} + APP_FOLDERS: ${{ inputs.app-folders }} From 3123f0ae853537bb01ccb3607f69142b9290a79d Mon Sep 17 00:00:00 2001 From: Bertrand THOMAS Date: Fri, 20 Mar 2026 22:38:18 +0100 Subject: [PATCH 5/5] Update github reusable workflow --- .github/workflows/ci.yaml | 8 ++++---- .github/workflows/pkg.yaml | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 58c74c0..b827e19 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -37,13 +37,13 @@ jobs: markup-lint: name: Markup - uses: devpro/github-workflow-parts/.github/workflows/reusable-markup-lint.yml@a6cc8b1b98ab0783e0b1b95d8d6c81fa2be07e6a + uses: devpro/github-workflow-parts/.github/workflows/reusable-markup-lint.yml@c90ba46a93ca90123f57744b47e49c1a73962cea code-quality: name: Code needs: git-check if: needs.git-check.outputs.app_changed == 'true' || (github.event_name == 'workflow_dispatch' && inputs.run-code-quality) - uses: devpro/github-workflow-parts/.github/workflows/reusable-dotnet-quality.yml@a6cc8b1b98ab0783e0b1b95d8d6c81fa2be07e6a + uses: devpro/github-workflow-parts/.github/workflows/reusable-dotnet-quality.yml@c90ba46a93ca90123f57744b47e49c1a73962cea with: custom-commands: | ./scripts/mongodb-install.sh @@ -62,7 +62,7 @@ jobs: sonar-organization: ${{ vars.SONAR_ORG }} sonar-project-key: ${{ vars.SONAR_PROJECT_KEY }} sonar-project-name: Keeptrack - workflow-parts-version: a6cc8b1b98ab0783e0b1b95d8d6c81fa2be07e6a + workflow-parts-version: c90ba46a93ca90123f57744b47e49c1a73962cea secrets: fossa-api-key: ${{ secrets.FOSSA_API_KEY }} sonar-token: ${{ secrets.SONAR_TOKEN }} @@ -90,7 +90,7 @@ jobs: - name: "Web Api" image-name: "keeptrack-webapi" image-definition: "src/WebApi/Dockerfile" - uses: devpro/github-workflow-parts/.github/workflows/reusable-container-scan.yml@a6cc8b1b98ab0783e0b1b95d8d6c81fa2be07e6a + uses: devpro/github-workflow-parts/.github/workflows/reusable-container-scan.yml@c90ba46a93ca90123f57744b47e49c1a73962cea with: image-definition: ${{ matrix.image-definition }} image-name: ${{ matrix.image-name }} diff --git a/.github/workflows/pkg.yaml b/.github/workflows/pkg.yaml index a007f69..82d0668 100644 --- a/.github/workflows/pkg.yaml +++ b/.github/workflows/pkg.yaml @@ -28,7 +28,7 @@ jobs: permissions: id-token: write contents: read - uses: devpro/github-workflow-parts/.github/workflows/reusable-container-publication.yml@a6cc8b1b98ab0783e0b1b95d8d6c81fa2be07e6a + uses: devpro/github-workflow-parts/.github/workflows/reusable-container-publication.yml@c90ba46a93ca90123f57744b47e49c1a73962cea with: create-latest: ${{ github.ref_name == 'main' }} image-definition: ${{ matrix.image-definition }}