Update IDM schema #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the IDM JSON schema by removing deprecated fields and legacy identifiers, pruning required link‐mapping properties, and introducing a new additional_mappings section to better organize record‐type mappings.
- Remove unused enum values in shard creation mappings
- Prune
requiredproperties in the custom‐links definition - Eliminate top‐level external system identifiers and add a structured
additional_mappingsblock
Comments suppressed due to low confidence (3)
initial_mappings_schema.yaml:193
- Only
reverse_stock_typesremains required after removinglink_type_names,source_types, andtarget_types. Please confirm this change is intentional, as clients may expect all three fields for custom link mappings.
required:
initial_mappings_schema.yaml:463
- Removing
external_system_id(along withexternal_system_typeandimport_slug) alters the top-level schema and could break existing API clients. Verify whether these identifiers were intentionally deprecated or relocated.
record_type_category_mappings:
initial_mappings_schema.yaml:461
- [nitpick] The new
additional_mappingsproperty lacks a description. Consider adding a brief explanation of its purpose and expected structure to guide schema consumers.
additional_mappings:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the IDM JSON schema by removing deprecated fields and legacy identifiers, pruning required link‐mapping properties, and introducing a new additional_mappings section to better organize record‐type mappings.
Work item
https://app.devrev.ai/devrev/works/ISS-188589