Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): adapt to mobile view, fix primary color doesn't change #287

Merged
merged 1 commit into from May 15, 2022

Conversation

devrsi0n
Copy link
Owner

@devrsi0n devrsi0n commented May 15, 2022

Description

adapt to mobile view:
image

fix primary color doesn't change:
image

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Checklist

  • Unit tests and integration tests passed
  • No reduction in test coverage
  • Documentation is up to date (if appropriate)
  • Related issues linked using fixes #number

@vercel
Copy link

vercel bot commented May 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
chirpy ✅ Ready (Inspect) Visit Preview May 15, 2022 at 8:47AM (UTC)

@relativeci
Copy link

relativeci bot commented May 15, 2022

Job #253: Bundle Size — 2.41MB (+0.18%).

0e25be9 vs 5eca60d

Changed metrics (8/10)
Metric Current Baseline
Initial JS 1.48MB(+0.04%) 1.48MB
Initial CSS 64.11KB(+6.24%) 60.35KB
Cache Invalidation 1.91% 21.14%
Chunks 54(+1.89%) 53
Assets 65(+1.56%) 64
Modules 1004(+0.4%) 1000
Duplicate Modules 156(+1.3%) 154
Duplicate Code 3.44%(+0.58%) 3.42%
Changed assets by type (2/7)
            Current     Baseline
CSS 67.36KB (+5.92%) 63.59KB
JS 2.33MB (+0.03%) 2.32MB

View Job #253 report on app.relative-ci.com

@github-actions
Copy link
Contributor

Coverage report for ./apps/main

Branches coverage not met for global: expected >=26%, but got 25.412035262552703%

St.
Category Percentage Covered / Total
🔴 Statements 37.26% 1909/5124
🔴 Branches 25.41% 663/2609
🔴 Functions 31.08% 349/1123
🔴 Lines 36.7% 1738/4736
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / index.ts
0% 0% 0% 0%
🔴
... / preview-data.ts
0% 100% 100% 0%
🔴
... / theme-editor.tsx
0% 0% 0% 0%

Test suite run success

53 tests passing in 35 suites.

Report generated by 🧪jest coverage report action from 69e3349

@devrsi0n devrsi0n changed the title feat(theme): adapt to mobile, fix primary color doesn't change feat(theme): adapt to mobile view, fix primary color doesn't change May 15, 2022
@cypress
Copy link

cypress bot commented May 15, 2022



Test summary

7 0 0 0


Run details

Project chirpy
Status Passed
Commit 69e3349
Started May 15, 2022 8:52 AM
Ended May 15, 2022 8:53 AM
Duration 01:16 💡
OS Linux Ubuntu - 20.04
Browser Electron 94

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@devrsi0n devrsi0n merged commit 0e25be9 into main May 15, 2022
@devrsi0n devrsi0n deleted the fix/theme-primary-color branch May 15, 2022 09:05
@devrsi0n
Copy link
Owner Author

Closed #176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant