Skip to content

Conversation

@erikhh
Copy link
Contributor

@erikhh erikhh commented Oct 29, 2020

This should fix #43

Normally I would have preferred to use Guava's Escaper class for this. But it was only available somewhere deep in the shaded part of Freebuilder and I didn't want to add an extra dependency for just this. So I opted for slightly less extensible manual option.

Copy link
Owner

@devshawn devshawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome -- thank you very much for the fix, @erikhh! I appreciate you not adding another dependency -- I'm happy with the manual function.

@devshawn devshawn merged commit c7e9ac7 into devshawn:master Oct 29, 2020
@erikhh erikhh deleted the escape-quotes-in-credentials branch October 30, 2020 07:57
@akabanov
Copy link

akabanov commented Aug 27, 2021

Don't want to be that guy, but what about escaping the escape character? :)
I'm just currently fixing the same issue in my project and lucky to already have org.apache.commons.text.StringEscapeUtils#escapeJava in the dependencies which works like a charm.

@erikhh
Copy link
Contributor Author

erikhh commented Aug 30, 2021

@akabanov I think the most effective way to get your point across is submitting a new PR with the proposed changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Double quotes in passwords are not escaped

3 participants