From b40b7f32f3763d4af7707dc18ae6747fea9ac81e Mon Sep 17 00:00:00 2001 From: Erik Hoogeveen Date: Thu, 29 Oct 2020 21:18:00 +0100 Subject: [PATCH] Fix for #43. Excape double quotes in credentials. --- .../kafka/gitops/config/KafkaGitopsConfigLoader.java | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/main/java/com/devshawn/kafka/gitops/config/KafkaGitopsConfigLoader.java b/src/main/java/com/devshawn/kafka/gitops/config/KafkaGitopsConfigLoader.java index 8b48b3d2..fe39a128 100644 --- a/src/main/java/com/devshawn/kafka/gitops/config/KafkaGitopsConfigLoader.java +++ b/src/main/java/com/devshawn/kafka/gitops/config/KafkaGitopsConfigLoader.java @@ -68,7 +68,7 @@ private static void handleAuthentication(AtomicReference username, Atomi } String value = String.format("%s required username=\"%s\" password=\"%s\";", - loginModule, username.get(), password.get()); + loginModule, escape(username.get()), escape(password.get())); config.put(SaslConfigs.SASL_JAAS_CONFIG, value); } else if (username.get() != null) { throw new MissingConfigurationException("KAFKA_SASL_JAAS_PASSWORD"); @@ -76,4 +76,11 @@ private static void handleAuthentication(AtomicReference username, Atomi throw new MissingConfigurationException("KAFKA_SASL_JAAS_USERNAME"); } } + + private static String escape(String value) { + if (value != null) { + return value.replace("\"", "\\\""); + } + return null; + } }