Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@Id is not supported with Vaadin 14 NPM mode #285

Open
johndevs opened this issue Sep 28, 2019 · 2 comments
Open

@Id is not supported with Vaadin 14 NPM mode #285

johndevs opened this issue Sep 28, 2019 · 2 comments
Labels
Projects

Comments

@johndevs
Copy link
Member

@johndevs johndevs commented Sep 28, 2019

Desktop:

  • OS: All supported
  • JDK version: All supported
  • Gradle version: All supported
  • Vaadin Plugin version: 1.3.beta1

Describe the bug

Right now when trying to render the following polymer template the component does not render:

@Tag("hello-button")
@JsModule("./hello-button.js")
public class HelloButton extends PolymerTemplate<HelloButton.HelloButtonModel> {

    @Id("caption")
    private Element caption;
}

If you remove the @Id annotation then the template will render OK. This is most likely some client side issue with the Vaadin Flow framework where some formatting is preventing the rendering.

Due to this if the project contains @Id tags the plugin will fail the build process.

To Reproduce
Steps to reproduce the behavior:

  1. Download the example project from here
  2. Run ./gradle vaadinTranspileDependencies --ignore-id-usage jettyRun
  3. Navigate to http://localhost:8080/<project name>
  4. The page is blank

Expected behavior
The opened page displays "Hello world" (renders the shadow dom)

Additional context
The issue is most likely either in how the shadow dom content is handled when the @id tag is present on the server side, or then a bug in client side shadow dom rendering.

@johndevs

This comment has been minimized.

Copy link
Member Author

@johndevs johndevs commented Sep 28, 2019

This issue is split out for further investigation from #240

@johndevs johndevs added the bug label Sep 28, 2019
@johndevs johndevs added this to To do in 1.3.x Sep 29, 2019
johndevs added a commit that referenced this issue Sep 29, 2019
@johndevs

This comment has been minimized.

Copy link
Member Author

@johndevs johndevs commented Sep 30, 2019

For the bounty to be payed out the following needs to be provided:

  1. A detailed description of what the issue is
  2. A proposed fix either to Vaadin Flow framework or to the gradle plugin

Only once the issue is fixed will the bounty be payed out.

@johndevs johndevs removed the hacktoberfest label Nov 4, 2019
@johndevs johndevs removed this from To do in 1.3.x Nov 4, 2019
@johndevs johndevs added this to Needs triage in Backlog via automation Nov 4, 2019
@johndevs johndevs moved this from Needs triage to High priority in Backlog Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Backlog
High priority
1 participant
You can’t perform that action at this time.