Skip to content
This repository has been archived by the owner before Nov 9, 2022. It is now read-only.

@Id is not supported with Vaadin 14 NPM mode #285

Closed
johndevs opened this issue Sep 28, 2019 · 2 comments
Closed

@Id is not supported with Vaadin 14 NPM mode #285

johndevs opened this issue Sep 28, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@johndevs
Copy link
Member

johndevs commented Sep 28, 2019

Desktop:

  • OS: All supported
  • JDK version: All supported
  • Gradle version: All supported
  • Vaadin Plugin version: 1.3.beta1

Describe the bug

Right now when trying to render the following polymer template the component does not render:

@Tag("hello-button")
@JsModule("./hello-button.js")
public class HelloButton extends PolymerTemplate<HelloButton.HelloButtonModel> {

    @Id("caption")
    private Element caption;
}

If you remove the @Id annotation then the template will render OK. This is most likely some client side issue with the Vaadin Flow framework where some formatting is preventing the rendering.

Due to this if the project contains @Id tags the plugin will fail the build process.

To Reproduce
Steps to reproduce the behavior:

  1. Download the example project from here
  2. Run ./gradle vaadinTranspileDependencies --ignore-id-usage jettyRun
  3. Navigate to http://localhost:8080/<project name>
  4. The page is blank

Expected behavior
The opened page displays "Hello world" (renders the shadow dom)

Additional context
The issue is most likely either in how the shadow dom content is handled when the @id tag is present on the server side, or then a bug in client side shadow dom rendering.

@johndevs
Copy link
Member Author

johndevs commented Sep 28, 2019

This issue is split out for further investigation from #240

@johndevs johndevs added bug Something isn't working help wanted Extra attention is needed labels Sep 28, 2019
@johndevs
Copy link
Member Author

johndevs commented Sep 30, 2019

For the bounty to be payed out the following needs to be provided:

  1. A detailed description of what the issue is
  2. A proposed fix either to Vaadin Flow framework or to the gradle plugin

Only once the issue is fixed will the bounty be payed out.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Development

No branches or pull requests

1 participant