From 61e98504ab6e8de9ba599696e5d17af5e9efd5c2 Mon Sep 17 00:00:00 2001 From: Mahendra Bagul Date: Tue, 6 Sep 2022 17:55:22 +0530 Subject: [PATCH 1/2] fixed issue in devspace init command --- cmd/init.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/cmd/init.go b/cmd/init.go index 33c5904325..e77a773b36 100644 --- a/cmd/init.go +++ b/cmd/init.go @@ -791,7 +791,7 @@ func (cmd *InitCmd) render(f factory.Factory, config *latest.Config) (string, er writer := &bytes.Buffer{} renderCmd := &RunPipelineCmd{ GlobalFlags: &flags.GlobalFlags{ - Silent: true, + Silent: false, ConfigPath: renderPath, }, Pipeline: "deploy", @@ -799,7 +799,6 @@ func (cmd *InitCmd) render(f factory.Factory, config *latest.Config) (string, er SkipBuild: true, Render: true, RenderWriter: writer, - Log: &log.DiscardLogger{}, } err = renderCmd.RunDefault(f) if err != nil { From 2e41d084d87456e34719327e3e2e5652439f2a04 Mon Sep 17 00:00:00 2001 From: Mahendra Bagul Date: Tue, 6 Sep 2022 18:14:03 +0530 Subject: [PATCH 2/2] fix: review comment - set silent to false only when debug is enabled. --- cmd/init.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/cmd/init.go b/cmd/init.go index e77a773b36..35bd227aa6 100644 --- a/cmd/init.go +++ b/cmd/init.go @@ -787,11 +787,15 @@ func (cmd *InitCmd) render(f factory.Factory, config *latest.Config) (string, er return "", errors.Wrap(err, "temp render.yaml") } + silent := true + if cmd.Debug { + silent = false + } // Use the render command to render it. writer := &bytes.Buffer{} renderCmd := &RunPipelineCmd{ GlobalFlags: &flags.GlobalFlags{ - Silent: false, + Silent: silent, ConfigPath: renderPath, }, Pipeline: "deploy",