-
Notifications
You must be signed in to change notification settings - Fork 198
fix: show non-existent plugin config #847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
In #795 , @IronCore864 thinks that templates are less suitable to be exported by command, but are suitable to be placed under Now two concurrent |
@iyear I've left a comment under #795. Let's have more discussions there. |
|
For quickstart printing logic, my original design was "when We can follow this idea to fix it first. As for whether to delete the logic of |
daniel-hutao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see #847 (comment)
|
devstream/internal/pkg/show/config/config.go Lines 22 to 24 in 2c8ba2d
Then I have to remove this code. |
|
I looked at the code and we need to prioritize support for @iyear Please also check if the documentation needs to be updated. Releated issue: #597 |
|
@daniel-hutao Is it possible to review and then merge in? I will start working on #795, otherwise it will cause a conflict. |
Signed-off-by: iyear <ljyngup@gmail.com>
Pre-Checklist
Note: please complete ALL items in the following checklist.
Description
I remove the default value of
template. We can discuss better solution.Related Issues
close #841
New Behavior (screenshots if needed)