refactor: kubectl plugin installer #867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steinliber
changed the title
steinliber
changed the title
iyear
reviewed
Jul 19, 2022
steinliber
requested review from
IronCore864,
aFlyBird0,
daniel-hutao,
iyear,
summingyu and
xavier-hou
xavier-hou
requested changes
Jul 20, 2022
xavier-hou
reviewed
Jul 20, 2022
xavier-hou
reviewed
Jul 20, 2022
xavier-hou
reviewed
Jul 20, 2022
iyear
reviewed
Jul 20, 2022
iyear
reviewed
Jul 20, 2022
iyear
reviewed
Jul 20, 2022
Member
|
Nice refactoring! |
IronCore864
approved these changes
Jul 20, 2022
Member
IronCore864
left a comment
IronCore864
left a comment
There was a problem hiding this comment.
Tested locally, gitops works.
Member
|
@steinliber Some conflicts here. And nearly 500 lines of code is a bit much, so I recommend splitting commits of this size into multiple pr in the future. |
daniel-hutao
requested changes
Jul 20, 2022
iyear
approved these changes
Jul 20, 2022
steinliber
force-pushed
the
feat-refactor-kubectl-plugin-installer
branch
from
701fba4 to
3391737
Compare
xavier-hou
approved these changes
Jul 20, 2022
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
steinliber
force-pushed
the
feat-refactor-kubectl-plugin-installer
branch
from
3391737 to
95d9859
Compare
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Meng JiaFeng jiafeng.meng@merico.dev
Pre-Checklist
Note: please complete ALL items in the following checklist.
Description
argocdappanddevlakeare all been tested.Related Issues
Subtask of #850
New Behavior (screenshots if needed)