refactor: all plugin use githubaction refactor #870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iyear
reviewed
Jul 20, 2022
iyear
reviewed
Jul 20, 2022
iyear
reviewed
Jul 20, 2022
iyear
reviewed
Jul 20, 2022
iyear
reviewed
Jul 20, 2022
iyear
reviewed
Jul 20, 2022
Member
|
Very nice refactoring. Very elegant! 🚀 |
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
steinliber
force-pushed
the
feat-refactor-github-plugin-installer
branch
from
adb1c86 to
b55a4bd
Compare
iyear
approved these changes
Jul 20, 2022
IronCore864
approved these changes
Jul 20, 2022
Member
|
Great work. Merging now. |
Member
|
@steinliber please make sure the latest e2e-test running on the main branch after merging is successful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Meng JiaFeng jiafeng.meng@merico.dev
Pre-Checklist
Note: please complete ALL items in the following checklist.
Description
Related Issues
Subtask of #850
New Behavior (screenshots if needed)
Current golang githubaction create method
