From 41321f3cb1a60727971d9f24297f0edd76570054 Mon Sep 17 00:00:00 2001 From: hxcGit Date: Wed, 20 Jul 2022 18:24:54 +0800 Subject: [PATCH 1/2] fix: stop e2e test when encounter errors Signed-off-by: hxcGit --- hack/e2e/e2e-run.sh | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/hack/e2e/e2e-run.sh b/hack/e2e/e2e-run.sh index f015a2332..974c6c976 100755 --- a/hack/e2e/e2e-run.sh +++ b/hack/e2e/e2e-run.sh @@ -66,10 +66,28 @@ function run_test() { echo "[dtm e2e test script] Start dtm e2e test locally!" ./dtm apply -f ${CONFIG_FILENAME} -y + if [ $? -ne 0 ]; then + echo "[dtm e2e test script] Execute dtm apply failed!" + clean_up + exit 1 + fi + check_status ./dtm verify -f ${CONFIG_FILENAME} + if [ $? -ne 0 ]; then + echo "[dtm e2e test script] Execute dtm verify failed!" + clean_up + exit 1 + fi + ./dtm delete -f ${CONFIG_FILENAME} -y + if [ $? -ne 0 ]; then + echo "[dtm e2e test script] Execute dtm delete failed!" + clean_up + exit 1 + fi + cd - } From f95db5b1b8fbc0207f6ad7373e8b54d6cc70c20d Mon Sep 17 00:00:00 2001 From: hxcGit Date: Thu, 21 Jul 2022 09:45:25 +0800 Subject: [PATCH 2/2] fix: add quotes to avoid yaml marshaling error Signed-off-by: hxcGit --- test/e2e/yaml/e2e-test-local.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/e2e/yaml/e2e-test-local.yaml b/test/e2e/yaml/e2e-test-local.yaml index 48a835879..b7b6a8925 100644 --- a/test/e2e/yaml/e2e-test-local.yaml +++ b/test/e2e/yaml/e2e-test-local.yaml @@ -20,7 +20,7 @@ tools: owner: [[ githubUsername ]] repo: [[ repoName ]] branch: [[ defaultBranch ]] - image_repo: [[ dockerRegistryUserName ]]/[[ repoName ]] + image_repo: "[[ dockerRegistryUserName ]]/[[ repoName ]]" - name: githubactions-golang instanceID: default dependsOn: ["github-repo-scaffolding-golang.default"]