Differential blueprint-create#94
Merged
Merged
Conversation
This is necessary for the next commit(s).
The blueprint JSON format is reconstituted in Python as a dict-of-dicts-and-lists but in reality the format involves a lot of defaultdict and set objects, which have nicer APIs for use in live Blueprint objects. The constructor now uses the walk algorithm with a set of callbacks that reconstitute the rich object structure with the same data.
This allows blueprints to be created relative to another, resulting in less duplication and more potential for modularity.
Member
Author
|
Our original discussion called for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the
--diffoption toblueprint-createwhich supports creating blueprints relative to another one. Specifically, the blueprint named by the--diffoption is subtracted from the newly created blueprint before it is committed as usual. Using a base blueprint as the--diffwould allow the evolution of a customization on top of it (and vice versa, though this is a bit tougher to reason about).