Scoped expression evaluation #2564
Scoped expression evaluation #2564
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2564 +/- ##
==========================================
+ Coverage 57.68% 57.74% +0.06%
==========================================
Files 51 51
Lines 1985 1988 +3
Branches 398 400 +2
==========================================
+ Hits 1145 1148 +3
Misses 840 840
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
||
expect(selectors.getExpression(getState(), "foo").value).to.be(null); | ||
expect(selectors.getExpression(getState(), "bar").value).to.be(null); | ||
await dispatch(actions.evaluateExpressions("boo")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this have a frame?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not sure how i'll mock the frame?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh - i didnt see you were passing frameId in w/ boo. that's good enough for this test :)
* evaluate expressions in selected scope * fix lint issues
Associated Issue: #2265
Summary of Changes
evaluateExpressions
Test Plan