Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Scoped expression evaluation #2564

Merged

Conversation

bomsy
Copy link
Contributor

@bomsy bomsy commented Apr 6, 2017

Associated Issue: #2265

Summary of Changes

  • Get the frameId of the current selected scope
  • Pass the frameId to evaluateExpressions
  • Added tests

Test Plan

  • Pause on breakpoint
  • Add an expression
  • Select a different stack frame
  • Check the expression

@codecov
Copy link

codecov bot commented Apr 6, 2017

Codecov Report

Merging #2564 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2564      +/-   ##
==========================================
+ Coverage   57.68%   57.74%   +0.06%     
==========================================
  Files          51       51              
  Lines        1985     1988       +3     
  Branches      398      400       +2     
==========================================
+ Hits         1145     1148       +3     
  Misses        840      840
Impacted Files Coverage Δ
src/actions/expressions.js 82.05% <100%> (+1.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3581ee...16f6177. Read the comment docs.

Copy link
Contributor

@jasonLaster jasonLaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


expect(selectors.getExpression(getState(), "foo").value).to.be(null);
expect(selectors.getExpression(getState(), "bar").value).to.be(null);
await dispatch(actions.evaluateExpressions("boo"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this have a frame?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not sure how i'll mock the frame?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh - i didnt see you were passing frameId in w/ boo. that's good enough for this test :)

@jasonLaster jasonLaster merged commit ddd3caf into firefox-devtools:master Apr 6, 2017
@bomsy bomsy deleted the scoped-expression-evaluation branch April 7, 2017 00:41
DanUgelow pushed a commit to DanUgelow/debugger.html that referenced this pull request May 4, 2017
* evaluate expressions in selected scope

* fix lint issues
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants