ExtJS recognition for call stack collapsing #2886
Conversation
Hm... I think I choked
PS: I've used |
Thanks @Eccenux! The patch looks good. Mind sharing a before/after screenshot or perhaps GIF? |
minor lint issue, which i can fix up |
Codecov Report
@@ Coverage Diff @@
## master #2886 +/- ##
==========================================
+ Coverage 63.37% 63.38% +0.01%
==========================================
Files 68 68
Lines 2468 2472 +4
Branches 506 507 +1
==========================================
+ Hits 1564 1567 +3
- Misses 904 905 +1
Continue to review full report at Codecov.
|
Fixed linter issue! @jasonLaster |
@Eccenux Hi! I do not see the logo (but the rest looks like it is working, great work)! I think it might be due to the file being generated by inkscape. Any ideas? |
@codehag Not sure what is going on. The SVG displays fine in my Firefox. But I simplified the file and modified units. I'm guessing different units and possibly some extra namespaces Inkscape is using might cause problems. |
Summary of Changes
This is similar to #2868. Just another framework.
Test Plan
ExtJS is collapsed.