This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Release a new version of the debugger #3098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jasonLaster
commented
Jun 6, 2017
jasonLaster
commented
- Updates from the past week
- Small fixes for the editor footer and a couple small details for tests
Codecov Report
@@ Coverage Diff @@
## master #3098 +/- ##
=======================================
Coverage 66.28% 66.28%
=======================================
Files 76 76
Lines 2714 2714
Branches 549 549
=======================================
Hits 1799 1799
Misses 915 915
Continue to review full report at Codecov.
|
codehag
reviewed
Jun 6, 2017
| @@ -1,6 +1,9 @@ | |||
| .editor-wrapper { | |||
| --debug-line-background: rgba(226, 236, 247, 0.5); | |||
| --debug-line-border: rgb(145, 188, 219); | |||
| --editor-searchbar-height: 27px; | |||
| --editor-second-searchbar-height: 27px; | |||
There was a problem hiding this comment.
i know this is copy pasted, but do we need two separate declarations of the same value? 🤔
There was a problem hiding this comment.
probably not. that can be tweaked when we have a function search modal :)
codehag
reviewed
Jun 6, 2017
src/components/Editor/Tabs.js
Outdated
| @@ -50,7 +50,8 @@ function getHiddenTabs(sourceTabs: SourcesList, sourceTabEls) { | |||
| return sourceTabs.filter((tab, index) => { | |||
| // adding 10px helps account for cases where the tab might be offset by | |||
| // styling such as selected tabs which don't have a border. | |||
| return sourceTabEls[index].getBoundingClientRect().top > tabTopOffset + 10; | |||
| const el = sourceTabEls[index]; | |||
| return el && el.getBoundingClientRect().top > tabTopOffset + 10; | |||
There was a problem hiding this comment.
Nice! i would split this up more even, so that we know what is happening.
const element = sourceTabEls[index];
const hasTopOffset = (el) => (el.getBoundingClientRect().top > tabTopOffset + 10)
return element && hasTopOffset(element);There was a problem hiding this comment.
that's a good idea. I took it a couple step further lol.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.