New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the source tab hover effects feel more responsive #3845

Merged
merged 1 commit into from Sep 1, 2017

Conversation

Projects
None yet
4 participants
@darkwing
Contributor

darkwing commented Sep 1, 2017

This is just a rough proposal. My opinion is that the tab hover transitions are slow and appear labored. The labored feeling is due to speed, so I drastically sped up the transitions and they seem much more quick and elegant.

I know the project has loads of transitions so I guess I'd like to hear some opinions on this faster effect and see if we'd like to speed things up globally.

@codehag

This comment has been minimized.

Contributor

codehag commented Sep 1, 2017

hi @darkwing! thanks for the proposal, do you happen to have a screencap of the change?

@codehag

This comment has been minimized.

Contributor

codehag commented Sep 1, 2017

hm...now that i think about it, i guess showing transitions with gifs doesnt work all that well.. 🤔 ill pull and take a look in a little bit!

@wldcordeiro

This comment has been minimized.

Contributor

wldcordeiro commented Sep 1, 2017

@darkwing When I was implementing the Modal transition, I was pointed to this document http://design.firefox.com/photon/motion/motion.html Using the curve and 150ms would be a good transition time I think.

@darkwing darkwing force-pushed the darkwing:responsive-tabs branch from 0f206d4 to e561608 Sep 1, 2017

@codecov

This comment has been minimized.

codecov bot commented Sep 1, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (master@08fd802). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3845   +/-   ##
=========================================
  Coverage          ?   55.16%           
=========================================
  Files             ?      124           
  Lines             ?     4865           
  Branches          ?     1009           
=========================================
  Hits              ?     2684           
  Misses            ?     2181           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08fd802...e561608. Read the comment docs.

@darkwing

This comment has been minimized.

Contributor

darkwing commented Sep 1, 2017

Updated to .15s. Still think the lower speed seems nicer but branding is important.

@jasonLaster jasonLaster merged commit 327028e into devtools-html:master Sep 1, 2017

1 check failed

ci/circleci Your tests failed on CircleCI
Details

coderitual pushed a commit to coderitual/debugger.html that referenced this pull request Sep 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment