Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

[themes] Update the sidebar and accordion colors for the dark theme (… #3912

Merged
merged 2 commits into from Sep 7, 2017
Merged

Conversation

gabrielluong
Copy link
Member

#3909)

Associated Issue: #3909

Summary of Changes

  • In the dark theme, Sidebar background color is var(--grey-90) and Accordion header background color is #141416.
  • In the sources list, and add watch expression button, the background color needs to be var(--theme-sidebar-background).
  • The accordion header needs to be #141416 only in the dark theme and var(--theme-toolbar-background) in the light.

Screenshots

Before:
screen shot 2017-09-06 at 4 48 56 pm

After:
screen shot 2017-09-06 at 4 37 00 pm

@@ -43,6 +43,7 @@
}

.sources-list {
background-color: var(--theme-sidebar-background);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the list and not the panel?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@codecov
Copy link

codecov bot commented Sep 7, 2017

Codecov Report

Merging #3912 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3912      +/-   ##
==========================================
- Coverage   55.75%   55.73%   -0.03%     
==========================================
  Files         129      129              
  Lines        4902     4904       +2     
  Branches     1014     1015       +1     
==========================================
  Hits         2733     2733              
- Misses       2169     2171       +2
Impacted Files Coverage Δ
src/components/Editor/EditorMenu.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad186e9...b4e6203. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 7, 2017

Codecov Report

Merging #3912 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3912      +/-   ##
==========================================
- Coverage   55.75%   55.73%   -0.03%     
==========================================
  Files         129      129              
  Lines        4902     4904       +2     
  Branches     1014     1015       +1     
==========================================
  Hits         2733     2733              
- Misses       2169     2171       +2
Impacted Files Coverage Δ
src/components/Editor/EditorMenu.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad186e9...f09a708. Read the comment docs.

@jasonLaster jasonLaster merged commit 4df933c into firefox-devtools:master Sep 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants