New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sources] Reveal in tree opens the left sidebar #5885

Merged
merged 1 commit into from Apr 7, 2018

Conversation

Projects
None yet
3 participants
@marcobeltempo
Contributor

marcobeltempo commented Apr 7, 2018

Fixes Issue: #5869

Summary of Changes

When selecting Reveal in tree from the context menu, it now checks:

  • if the left panel is collapsed
    • opens if it is

Test Plan

  • Select Reveal in tree with the left panel closed to make sure it opened
  • Select Reveal in tree with the left panel opened to make sure it didn't collapse
  • With the context menu opened, enter Shift + Alt + r will also open the left panel

Screenshots/Videos

debugger_html_issue5869

@jasonLaster

Nice! This looks great. I’ll test it soon

@jasonLaster

This comment has been minimized.

Contributor

jasonLaster commented Apr 7, 2018

Thanks for the help!

By the way, you should join our slack https://devtools-html-slack.herokuapp.com/ and say hi!

@AnshulMalik

This is great!

@jasonLaster jasonLaster changed the title from Fixes #5869 - Opens the left sidebar when selecting to "Reveal in tree" to [Sources] Reveal in tree opens the left sidebar Apr 7, 2018

@AnshulMalik AnshulMalik merged commit 03618a6 into devtools-html:master Apr 7, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

jasonLaster added a commit that referenced this pull request Apr 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment