New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Trying out react@next #525

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@clarkbw
Member

clarkbw commented Jul 26, 2017

Trying out React 16 Beta

It works, but I don't think this is merge ready yet.

Mostly we've fallen behind the react train. I've updated PropTypes and CreateClass to their shims but if this moved to ES6 Modules and JSX that would help quite a bit further.

@@ -10,7 +10,7 @@
["module-resolver", {
"alias": {
"react-dom": "react-dom/dist/react-dom",
"react-dom": "react-dom/umd/react-dom.development",

This comment has been minimized.

@gaearon

gaearon Jul 26, 2017

Curious: what is the necessity for these aliases?

@gaearon

gaearon Jul 26, 2017

Curious: what is the necessity for these aliases?

This comment has been minimized.

@bvaughn

bvaughn Jul 26, 2017

Looks like it's forcing UMD instead of default (CJS) target?

@bvaughn

bvaughn Jul 26, 2017

Looks like it's forcing UMD instead of default (CJS) target?

This comment has been minimized.

@gaearon

gaearon Jul 26, 2017

Right. I’m curious why. In the past people used to do this to speed up DEV builds (since React had too many modules). But now CJS is also a single bundle so maybe it‘s unnecessary.

@gaearon

gaearon Jul 26, 2017

Right. I’m curious why. In the past people used to do this to speed up DEV builds (since React had too many modules). But now CJS is also a single bundle so maybe it‘s unnecessary.

This comment has been minimized.

@bvaughn

bvaughn Jul 26, 2017

Yeah, sorry. I wasn't really trying to answer your question so much as confirming that I understood what it was doing.

Your assertion seems legit.

@bvaughn

bvaughn Jul 26, 2017

Yeah, sorry. I wasn't really trying to answer your question so much as confirming that I understood what it was doing.

Your assertion seems legit.

This comment has been minimized.

@clarkbw

clarkbw Jul 27, 2017

Member

@jasonLaster is the right person to answer that question, my understanding is that this has to do with how we package react within the browser toolbox.

@clarkbw

clarkbw Jul 27, 2017

Member

@jasonLaster is the right person to answer that question, my understanding is that this has to do with how we package react within the browser toolbox.

This comment has been minimized.

@jasonLaster

jasonLaster Jul 27, 2017

Contributor

Here was the warning we saw:
devtools-html/debugger.html#1640

And the fix:
devtools-html/debugger.html#1731

We've had several other issues creep in over time
#179
#23

@jasonLaster

jasonLaster Jul 27, 2017

Contributor

Here was the warning we saw:
devtools-html/debugger.html#1640

And the fix:
devtools-html/debugger.html#1731

We've had several other issues creep in over time
#179
#23

This comment has been minimized.

@gaearon

gaearon Jul 27, 2017

So the issue is due to a custom module system (per #23)? I'm not sure what “single module plugin” is.

I guess if it works around a bug for you, that’s cool, I just wanted to verify. Please not react.development bundle is not suitable for production.

@gaearon

gaearon Jul 27, 2017

So the issue is due to a custom module system (per #23)? I'm not sure what “single module plugin” is.

I guess if it works around a bug for you, that’s cool, I just wanted to verify. Please not react.development bundle is not suitable for production.

@clarkbw

This comment has been minimized.

Show comment
Hide comment
@clarkbw

clarkbw Sep 13, 2017

Member

Closing this out for now, its a good start but will take some more work to make it happen. 🙇

Member

clarkbw commented Sep 13, 2017

Closing this out for now, its a good start but will take some more work to make it happen. 🙇

@clarkbw clarkbw closed this Sep 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment