Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorderable should not allow dragging with the right mouse button #322

Closed
mstange opened this issue May 11, 2017 · 5 comments
Closed

Reorderable should not allow dragging with the right mouse button #322

mstange opened this issue May 11, 2017 · 5 comments
Labels
good first issue Good issue for new contributors, the issue must have clear instructions on how to complete the work help wanted Things ready to be worked on by anyone. Issues must include instructions on how to complete the task

Comments

@mstange
Copy link
Contributor

mstange commented May 11, 2017

If you right-click on a thread name and drag down, the context menu opens and at the same time you're dragging the thread.
You shouldn't be dragging the thread.

@julienw julienw added the help wanted Things ready to be worked on by anyone. Issues must include instructions on how to complete the task label May 11, 2017
@julienw
Copy link
Contributor

julienw commented May 11, 2017

If a contributor would like to try this, the fix is adding a check for event.button in https://github.com/devtools-html/perf.html/blob/master/src/content/components/Reorderable.js#L42

@julienw julienw added the good first issue Good issue for new contributors, the issue must have clear instructions on how to complete the work label May 12, 2017
@morrme
Copy link

morrme commented May 13, 2017

Would the check be a part of the current conditional? and would it be for event.button == 1 ?

@julienw
Copy link
Contributor

julienw commented May 14, 2017

I'd do a if (event.button !== 0) { return } (with proper indentations :) ), separarely from the existing conditional for the sake of clarity.

@magopian
Copy link
Contributor

I believe this can now be closed as it was fixed in 70f3cd3

@julienw
Copy link
Contributor

julienw commented Jun 29, 2017

true :)

@julienw julienw closed this as completed Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good issue for new contributors, the issue must have clear instructions on how to complete the work help wanted Things ready to be worked on by anyone. Issues must include instructions on how to complete the task
Projects
None yet
Development

No branches or pull requests

4 participants