Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Network track for the timeline #1189
Edit: This is now ready for review, @ola, would you feel comfortable reviewing this? I have split the work into multiple logical commits, so it will be easiest to look at each in turn, rather than the whole at once. I still haven't reproduced the first-paint effect Markus describes below.
Also resolves #1196
@@ Coverage Diff @@ ## master #1189 +/- ## ========================================== + Coverage 75.9% 76.06% +0.15% ========================================== Files 144 145 +1 Lines 9364 9501 +137 Branches 2319 2350 +31 ========================================== + Hits 7108 7227 +119 - Misses 2013 2031 +18 Partials 243 243
referenced this pull request
Aug 14, 2018
This PR looks really good. :)
Besides the one question above, I realized that the markers in the network panel get updated when selecting a range, but the list is not updated (see screenshot, checked with following profile)
When you select a range for the marker-table, the markers as well as the list get updated.
When selecting just the network thread, the shadow makes it a bit hard so see the network markers in the thread. It also feels dense.
How would you feel about adding one more row or some additional padding at the bottom of the network thread (so increase the min-height), as the thread seems to get "swallowed" when it does not contain markers?
The shadow is created by the OverflowEdgeIndicator component. It should only show up when the timeline can scroll down, which this is not doing in your screenshots. I narrowed it down to an STR. I think we should fix this in a follow-up, I filed that as #1205.
This is #865.
Yeah, I can throw another row in there for that case. I feel like the network track being empty is a bit weird, although I think having it disappear might be confusing. Perhaps having it hide itself is a better option here?
+1 in hiding itself when it is empty. Do you want to file a follow up for this?
In case we have just very few markers and the row is still min-height, we can re-check again when it landed and file a follow up bug, if this still feels like it gets "swallowed".
Thank you for the changes :)