Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Hide idle threads #1218
This PR changes the way we hide idle threads. With the new category information, we can now know if a sample is idle or not. This change removes the previous guesses about not having RefreshDriverTicks in a main thread and generalizes the notion of an idle thread, so that it works for all sorts of threads.
Here is an example profile hash: https://deploy-preview-1218--perf-html.netlify.com/public/9123fab7068c9fa242d79396f257b614bcd67bce
@brisad, I pinged you for review on this. I don't think you've specifically looked at this part of the code before, but I think it should be understandable for what is going on.
@@ Coverage Diff @@ ## master #1218 +/- ## ========================================= + Coverage 75.88% 75.9% +0.02% ========================================= Files 144 144 Lines 9354 9364 +10 Branches 2316 2318 +2 ========================================= + Hits 7098 7108 +10 Misses 2013 2013 Partials 243 243
Thanks, the code was very clear indeed. Looks good to me!