Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Debugger empty UI links #29

Closed
violasong opened this issue Sep 11, 2018 · 2 comments
Closed

Improve Debugger empty UI links #29

violasong opened this issue Sep 11, 2018 · 2 comments

Comments

@violasong
Copy link
Contributor

See this bug for potential concerns about the understated look of the shortcut info/'links' when no tabs are open. Should we simply apply the photon ghost button styling, or is there a better solution here?

@yogmel
Copy link

yogmel commented Mar 9, 2019

I've been thinking for a while...that's not an easy question. As you mentioned in the conversation, I suppose it depends on this question:

How important is that the user knows that text is clickable?

a. Very important: make the button very obviously clickable, by changing the color of the text, its background color or insert an underline

b. It is good to know: maybe insert the photon ghost button of the New icon.

c. Not important, surprise them: a more showy hover state, such as changing the background color or the color to a brighter/different one.

This is hard, because all of these options would change the actual design which already looks perfect.
In any way, I agree with you, I don't believe making them button-like links is a solution.


What do you think? I can try working on some mockups to show them here.

@violasong violasong added this to Done in Victoria's Tasks Mar 14, 2019
@violasong
Copy link
Contributor Author

@yogmel Sorry for the extremely late reply! I think you made great points here.

I think this UI may have changed since this bug was filed? In any case, I think the current bolded shortcut with subtle text hover effect is probably fine for now. I'm more bothered by the fact that it's not vertically aligned ;) so I'll file a bug for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants