Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unhibernation is getting initiated for already unhibernated apps #4331

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

ashishdevtron
Copy link
Contributor

Description

fixes the case where bulk unhibernation is getting inititated for already unhibernated apps

Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Copy link

sonarcloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ashishdevtron ashishdevtron changed the base branch from main to changeci-fixes-oss December 1, 2023 13:19
@ashishdevtron ashishdevtron merged commit dead7cd into changeci-fixes-oss Dec 1, 2023
5 of 6 checks passed
@ashishdevtron ashishdevtron deleted the bulk-unhibernate-fix branch December 1, 2023 13:21
gireesh-naidu added a commit that referenced this pull request Dec 4, 2023
* 194 sql script fix

* fixes for stale artifacts cipipeline fetches

* fix: unhibernation is getting initiated for already unhibernated apps (#4331)

* fix for unhibernation for already unhibernated apps

* deployment status correction

* method change

* merge main

* added comment for up script 194

---------

Co-authored-by: subs <subhashish@devtron.ai>
Co-authored-by: ashishdevtron <141303172+ashishdevtron@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants