Few improvements #9

Merged
merged 3 commits into from Apr 18, 2012

Projects

None yet

3 participants

@sosedoff
Contributor

I made a few improvements to the library,

  1. Added request options for handling timeouts. Sometimes the request is being processed for a very long time (~ 30+ sec). Its a const now, but we could possibly make it a configurable option.
  2. Added JSON to runtime requirements. If you dont have any json library installed the whole test suite goes down.
@stve
Collaborator
stve commented Apr 16, 2012

The request options change looks good to me. I think it might be better to make json a development_dependency as we don't need to mandate a parser lib other than for development.

@sosedoff
Contributor

True that, i'll commit right now.

@dewski dewski merged commit f9f056a into dewski:master Apr 18, 2012
@dewski
Owner
dewski commented Apr 18, 2012

In the future if we add any configuration we can move REQUEST_OPTIONS, but for now that'll do. Nice job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment