/perl-Exception-Base

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly rethrow exceptions from unrelated classes #4

Open
wants to merge 2 commits into
base: master
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@choroba
@choroba

choroba commented Mar 9, 2018

Solves https://rt.cpan.org/Public/Bug/Display.html?id=79655
by not assuming the first argument to throw must be an Exception::Base
if it's a reference. If it doesn't inherit from Exception::Base, it's
wrapped in a new Exception::Base object which is then thrown.
@choroba
Correctly rethrow exceptions from unrelated classes 
Solves https://rt.cpan.org/Public/Bug/Display.html?id=79655
by not assuming the first argument to throw must be an Exception::Base
if it's a reference. If it doesn't inherit from Exception::Base, it's
wrapped in a new Exception::Base object which is then thrown.
c3f8568
@choroba

This comment has been minimized.

Sign in to view

choroba commented Mar 9, 2018

This PR is part of the CPAN Pull Request Challenge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment