Correctly rethrow exceptions from unrelated classes #4
Conversation
Solves https://rt.cpan.org/Public/Bug/Display.html?id=79655 by not assuming the first argument to throw must be an Exception::Base if it's a reference. If it doesn't inherit from Exception::Base, it's wrapped in a new Exception::Base object which is then thrown.
|
This PR is part of the CPAN Pull Request Challenge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Solves https://rt.cpan.org/Public/Bug/Display.html?id=79655
by not assuming the first argument to throw must be an Exception::Base
if it's a reference. If it doesn't inherit from Exception::Base, it's
wrapped in a new Exception::Base object which is then thrown.