Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let liveQuery() be type-wise compable with RxJS #1417

Merged
merged 3 commits into from Oct 27, 2021
Merged

Conversation

dfahlander
Copy link
Collaborator

@dfahlander dfahlander commented Oct 26, 2021

The Observable returned from liveQuery() is compatible with both RxJS and the current Ecmascript observable proposal. However, RxJS latest version requires the typing of it to have a [Symbol.observable] or else RxJS require the Observable to have all the Rx-specific old and deprecated properties on it.

In order for make it not just runtime compatible with RxJS but also in its typings, we need to patch the global Symbol type with an observable property just as RxJS does in its typings (according to Ecmascript observable proposal. This global type patching does not conflict with neither RxJs or ES proposal as of current.

@dfahlander dfahlander merged commit c0875ef into master Oct 27, 2021
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant