Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mending enchantment #552

Merged
merged 16 commits into from
Jul 16, 2022
Merged

Mending enchantment #552

merged 16 commits into from
Jul 16, 2022

Conversation

HashimTheArab
Copy link
Contributor

@HashimTheArab HashimTheArab commented Jul 11, 2022 •
edited by JustTalDevelops
Loading

Resolves #567.

2022-07-11.01-55-40.mov

@JustTalDevelops JustTalDevelops added the feature New feature or request label Jul 14, 2022
@JustTalDevelops JustTalDevelops mentioned this pull request Jul 14, 2022
Open
89 tasks
Sandertv
Sandertv requested changes Jul 15, 2022
View reviewed changes
Copy link
Member

@Sandertv Sandertv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a couple of comments. Functionally the code looks fine to me, so it shouldn't be too much more work.

server/item/enchantment/mending.go Outdated Show resolved Hide resolved
server/player/player.go Outdated Show resolved Hide resolved
server/player/player.go Outdated Show resolved Hide resolved
server/player/player.go Outdated Show resolved Hide resolved
Sandertv
Sandertv reviewed Jul 16, 2022
View reviewed changes
Copy link
Member

@Sandertv Sandertv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one last comment, feel free to ping me on Discord once you've resolved it. Should be good to merge after it.

server/player/player.go Outdated Show resolved Hide resolved
@Sandertv Sandertv self-assigned this Jul 16, 2022
@JustTalDevelops JustTalDevelops merged commit ff76b6f into df-mc:master Jul 16, 2022
@HashimTheArab HashimTheArab deleted the enchantment/mending branch July 16, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sandertv Sandertv Sandertv requested changes

@JustTalDevelops JustTalDevelops JustTalDevelops approved these changes

Assignees

@Sandertv Sandertv

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement mending
3 participants
@HashimTheArab @Sandertv @JustTalDevelops