Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

item/fire_charge.go: Implement the fire charge item #621

Merged
merged 3 commits into from
Aug 1, 2022
Merged

item/fire_charge.go: Implement the fire charge item #621

merged 3 commits into from
Aug 1, 2022

Conversation

AndreasHGK
Copy link
Contributor

No description provided.

Sandertv
Sandertv requested changes Aug 1, 2022
View reviewed changes
Copy link
Member

@Sandertv Sandertv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I've got two comments, should be easily resolved. I think this looks good otherwise!

server/item/fire_charge.go Outdated Show resolved Hide resolved
server/world/sound/item.go Outdated Show resolved Hide resolved
Sandertv
Sandertv approved these changes Aug 1, 2022
View reviewed changes
Copy link
Member

@Sandertv Sandertv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for the PR!

@Sandertv Sandertv merged commit 5acab63 into df-mc:master Aug 1, 2022
@DaPigGuy DaPigGuy mentioned this pull request Aug 1, 2022
Open
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sandertv Sandertv Sandertv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreasHGK @Sandertv