Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement frosted ice and frost walker #722

Closed
wants to merge 7 commits into from
Closed

implement frosted ice and frost walker #722

wants to merge 7 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 24, 2022

This PR implements frosted ice and frost walker as defined by the linked pages.

Some features of frost walker are currently impossible to implement:

  • Foxes can pick up boots with frost walker, but foxes do not exist in Dragonfly
  • Frost walker prevents damage from campfires and magma blocks when stepped on, but neither exist in Dragonfly

Currently, the main function contains code that spawns players with boots enchanted with frost walker one and two, and a bucket of water, for testing purposes.

Copy link
Member

@DaPigGuy DaPigGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a preliminary review, I haven't checked the actual Frosted Ice/Frost Walker logic yet.

server/block/water.go Outdated Show resolved Hide resolved
server/item/enchantment/frost_walker.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
server/block/frosted_ice.go Outdated Show resolved Hide resolved
server/block/frosted_ice.go Outdated Show resolved Hide resolved
server/block/frosted_ice.go Outdated Show resolved Hide resolved
server/block/frosted_ice.go Show resolved Hide resolved
server/block/frosted_ice.go Outdated Show resolved Hide resolved
server/block/frosted_ice.go Show resolved Hide resolved
server/block/frosted_ice.go Outdated Show resolved Hide resolved
server/block/frosted_ice.go Outdated Show resolved Hide resolved
server/player/player.go Show resolved Hide resolved
server/block/frosted_ice.go Outdated Show resolved Hide resolved
server/block/frosted_ice.go Outdated Show resolved Hide resolved
server/block/frosted_ice.go Outdated Show resolved Hide resolved
server/block/frosted_ice.go Outdated Show resolved Hide resolved
server/block/frosted_ice.go Outdated Show resolved Hide resolved
server/block/frosted_ice.go Outdated Show resolved Hide resolved
@DaPigGuy DaPigGuy mentioned this pull request Dec 29, 2022
89 tasks
Copy link
Member

@DaPigGuy DaPigGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FrostedIce must implement both the ScheduledTicker and NeighbourUpdateTicker, and have scheduled updates queued on neighbor updates.

@ghost
Copy link
Author

ghost commented Jan 14, 2023

FrostedIce must implement both the ScheduledTicker and NeighbourUpdateTicker, and have scheduled updates queued on neighbor updates.

Why?

@JustTalDevelops JustTalDevelops added the feature New feature or request label Jan 15, 2023
@ghost ghost closed this by deleting the head repository Mar 21, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants