Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support idle management in AuthClient #547

Merged
merged 25 commits into from
Mar 30, 2022

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Mar 25, 2022

Description

Introduces a new IdleManager to detect when a user has gone idle, and calling callbacks

Fixes SDK-307

How Has This Been Tested?

  • Unit tests
  • in krpeacock/auth-client-demo

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock force-pushed the SDK-307-support-invalidating-and-replacing-identities branch from 51be652 to e826b43 Compare March 29, 2022 21:26
@krpeacock
Copy link
Contributor Author

I made the JS docs a little more verbose, but it does a better job of revealing the full API in intellisense
image

@krpeacock krpeacock requested a review from a team March 29, 2022 21:31
@krpeacock krpeacock changed the title feat: support invalidating and replacing identities in AuthClient feat: support idle management in AuthClient Mar 29, 2022
Copy link
Contributor

@dfx-json dfx-json left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. The tests were clear and the code was easy to understand. I left one comment about whether this would ever need to be used in a nodejs environment - it wouldn't support that as-is clearly, but is environment compatibility something we should add to the README?

func.apply(context, args);
};
clearTimeout(timeout);
timeout = window.setTimeout(later, wait);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is auth-client ever meant to be used in a nodejs environment?

@krpeacock krpeacock merged commit 178cb01 into main Mar 30, 2022
@krpeacock krpeacock deleted the SDK-307-support-invalidating-and-replacing-identities branch March 30, 2022 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants