Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds UTF-8 as an encoding option #587

Merged
merged 5 commits into from
Jul 1, 2022
Merged

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Jul 1, 2022

Description

Adds UTF-8 as an encoding option for CanisterStatus custom paths

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock changed the title feat: adds UTF-8 as an encoding optio feat: adds UTF-8 as an encoding option Jul 1, 2022
@krpeacock krpeacock requested a review from a team July 1, 2022 23:08
@krpeacock krpeacock enabled auto-merge (squash) July 1, 2022 23:11
@krpeacock krpeacock merged commit 407b0df into main Jul 1, 2022
@krpeacock krpeacock deleted the kyle/canisterstatus-utf8 branch July 1, 2022 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants