-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ECDSAKeyIdentity #591
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Status check names include matrix elements. This means that required status names would have to change if any of those matrix elements changed in the future. This change aggregates these checks into a single status check with a constant name, suitable for use as a required status. Fixes https://dfinity.atlassian.net/browse/SDK-582
…#593) * feat: enables inline sourcemaps for packages for developer experience
…/agent-js into SDK-554-ecdsakeyidentity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see detailed comments. We may want to set up a 1-1 to resolve things.
packages/identity/src/identity/__snapshots__/ecdsa.test.ts.snap
Outdated
Show resolved
Hide resolved
…/agent-js into SDK-554-ecdsakeyidentity
Dfinity-Bjoern
approved these changes
Jul 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good now.
packages/identity/src/identity/__snapshots__/ecdsa.test.ts.snap
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces a new Identity type that wraps the native interfaces of the SubtleCrypto interface.
Note: during development, I had to update TypeScript, Jest, and some other testing utilities to support the webcrypto API that we are now using. Changes outside @dfinity/identity are simply to support those updates
Checklist: