Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ECDSAKeyIdentity #591

Merged
merged 54 commits into from
Jul 22, 2022
Merged

feat: ECDSAKeyIdentity #591

merged 54 commits into from
Jul 22, 2022

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Jul 11, 2022

Description

Introduces a new Identity type that wraps the native interfaces of the SubtleCrypto interface.

Note: during development, I had to update TypeScript, Jest, and some other testing utilities to support the webcrypto API that we are now using. Changes outside @dfinity/identity are simply to support those updates

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from a team as a code owner July 11, 2022 23:30
krpeacock and others added 14 commits July 12, 2022 09:53
Status check names include matrix elements.  This means that required status names would have to change if any of those matrix elements changed in the future.

This change aggregates these checks into a single status check with a constant name, suitable for use as a required status.

Fixes https://dfinity.atlassian.net/browse/SDK-582
…#593)

* feat: enables inline sourcemaps for packages for developer experience
Copy link
Member

@Dfinity-Bjoern Dfinity-Bjoern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see detailed comments. We may want to set up a 1-1 to resolve things.

e2e/node/basic/identity.test.ts Outdated Show resolved Hide resolved
e2e/node/basic/identity.test.ts Outdated Show resolved Hide resolved
packages/identity/src/identity/ecdsa.ts Outdated Show resolved Hide resolved
packages/identity/src/identity/ecdsa.ts Outdated Show resolved Hide resolved
packages/identity/src/identity/ecdsa.ts Outdated Show resolved Hide resolved
packages/identity/src/identity/ecdsa.ts Outdated Show resolved Hide resolved
packages/identity/src/identity/ecdsa.ts Outdated Show resolved Hide resolved
Copy link
Member

@Dfinity-Bjoern Dfinity-Bjoern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good now.

packages/identity/src/identity/ecdsa.ts Show resolved Hide resolved
@krpeacock krpeacock merged commit 245b029 into main Jul 22, 2022
@krpeacock krpeacock deleted the SDK-554-ecdsakeyidentity branch July 22, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants