Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose storage constant keys #616

Merged
merged 4 commits into from
Sep 20, 2022
Merged

feat: expose storage constant keys #616

merged 4 commits into from
Sep 20, 2022

Conversation

peterpeterparker
Copy link
Member

Description

For maintainability reason, it can be interesting for consumer of the auth-client to be able to use the storage constant keys.

e.g. in NNS-dapp we have a worker that checks the delegation validity and get the value through IdbStorage but, we have to specify the key "manually".

Notes

Another option, rather than exporting the constants, would be to add two dedicated functions to IdbStorage - e.g. getDelegation and getIdentity - just went with the smaller solution.

Checklist:

@peterpeterparker peterpeterparker requested a review from a team as a code owner August 24, 2022 05:28
@peterpeterparker peterpeterparker changed the title feat: expose storage keys feat: expose storage constant keys Aug 24, 2022
@krpeacock krpeacock merged commit 58a892a into main Sep 20, 2022
@krpeacock krpeacock deleted the feat/expose-idb-keys branch September 20, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants