Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AgentJs Candid Pinpointed Type Errors upgrade - PR #633

Merged
merged 3 commits into from
Sep 30, 2022

Conversation

infu
Copy link
Contributor

@infu infu commented Sep 29, 2022

@infu infu requested a review from a team as a code owner September 29, 2022 16:40
@infu infu changed the title AgentJs Candid Pinpointed Type Errors upgrade - PR feat!: AgentJs Candid Pinpointed Type Errors upgrade - PR Sep 29, 2022
@krpeacock
Copy link
Contributor

@chenyan-dfinity @rvanasa I think this change makes sense. Do you see any reason we shouldn't throw errors at the various points covariants are invalid?

Copy link
Contributor

@chenyan-dfinity chenyan-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krpeacock krpeacock changed the title feat!: AgentJs Candid Pinpointed Type Errors upgrade - PR feat: AgentJs Candid Pinpointed Type Errors upgrade - PR Sep 29, 2022
@krpeacock
Copy link
Contributor

@infu I had to change the title - you were following conventional commits correctly - the CI bot itself is wrong

@krpeacock krpeacock merged commit 9865757 into dfinity:main Sep 30, 2022
@infu infu mentioned this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants