Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cargo): consolidate versions and project organization #35

Merged
merged 4 commits into from
Jan 8, 2024
Merged

feat(cargo): consolidate versions and project organization #35

merged 4 commits into from
Jan 8, 2024

Conversation

sasa-tomic
Copy link
Member

  • Use workspace versions, instead of per-project
  • Rename the release_cli binary to dre

@sasa-tomic sasa-tomic requested a review from a team as a code owner January 5, 2024 12:08
nikola-milosa
nikola-milosa approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@nikola-milosa nikola-milosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion its a nice change, probably should wait for more opinions.

@sasa-tomic sasa-tomic merged commit dbf0cc3 into main Jan 8, 2024
3 checks passed
@sasa-tomic sasa-tomic deleted the sat-workspace-version branch January 8, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikola-milosa nikola-milosa nikola-milosa approved these changes

@pietrodimarco-dfinity pietrodimarco-dfinity pietrodimarco-dfinity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sasa-tomic @nikola-milosa @pietrodimarco-dfinity