Skip to content

Conversation

@letmejustputthishere
Copy link
Contributor

Overview
Why do we need this feature? What are we trying to accomplish?

Requirements
What requirements are necessary to consider this problem solved?

Considered Solutions
What solutions were considered?

Recommended Solution
What solution are you recommending? Why?

Considerations
What impact will this change have on security, performance, users (e.g. breaking changes) or the team (e.g. maintenance costs)?

@letmejustputthishere letmejustputthishere requested a review from a team as a code owner August 7, 2025 15:39
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates a React frontend project from TypeScript to plain JavaScript, removing TypeScript configurations and type annotations throughout the codebase.

  • Removes all TypeScript configuration files (tsconfig.json files)
  • Converts TypeScript files (.tsx, .ts) to JavaScript files (.jsx, .js)
  • Removes TypeScript type annotations and interfaces from all components and hooks

Reviewed Changes

Copilot reviewed 15 out of 20 changed files in this pull request and generated no comments.

Show a summary per file
File Description
motoko/nft-creator/tsconfig.json Removes root TypeScript configuration file
motoko/nft-creator/frontend/tsconfig.json Removes frontend TypeScript configuration file
motoko/nft-creator/frontend/src/types.ts Removes TypeScript type definitions file
motoko/nft-creator/frontend/src/main.jsx Removes TypeScript non-null assertion operator
motoko/nft-creator/frontend/src/index.css Minor formatting change to CSS property line breaks
motoko/nft-creator/frontend/src/hooks/useQueries.js Removes TypeScript type annotations and imports
motoko/nft-creator/frontend/src/hooks/useActor.js Removes TypeScript type annotations and imports
motoko/nft-creator/frontend/src/contexts/ToastContext.tsx Removes TypeScript version of ToastContext
motoko/nft-creator/frontend/src/contexts/ToastContext.jsx Adds JavaScript version of ToastContext without type annotations
motoko/nft-creator/frontend/src/components/NFTCard.jsx Removes TypeScript interfaces and type annotations
motoko/nft-creator/frontend/src/components/MintNFT.jsx Adds error handling for invalid principals
motoko/nft-creator/frontend/src/App.tsx Removes TypeScript version of App component
motoko/nft-creator/frontend/src/App.jsx Adds JavaScript version of App component
motoko/nft-creator/frontend/package.json Removes TypeScript dependencies and build step
motoko/nft-creator/frontend/index.html Updates script reference from .tsx to .jsx
Files not reviewed (1)
  • motoko/nft-creator/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)

motoko/nft-creator/frontend/src/hooks/useQueries.js:25

  • The removeToast function is referenced in the setTimeout callback before it's defined. This will cause a ReferenceError since removeToast is defined later in the component using useCallback.
        queryKey: ["collectionOwner"],

@marc0olo marc0olo merged commit b564d21 into master Aug 8, 2025
9 checks passed
@marc0olo marc0olo deleted the fix/migrate-to-ts branch August 8, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants