feat(agent): lookup canister ranges using the /canister_ranges/<subnet_id>/<ranges> certificate path
#1221
+108
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et_id>/<ranges>` certificate path
Contributor
size-limit report 📦
|
4 tasks
4 tasks
4 tasks
viviveevee
approved these changes
Dec 2, 2025
ilbertt
added a commit
that referenced
this pull request
Dec 2, 2025
ilbertt
added a commit
that referenced
this pull request
Dec 2, 2025
# Description Switches the agent to using `/api/v4` for update (call) requests. Should validate certificates using #1221. Blocked by #1227. # How Has This Been Tested? The mock replica and the url assertion tests have been updated to use v4. I'll update the mock replica to return a v4 certificate in a follow-up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prepares the
check_canister_rangesto support the certificate returned by the new versions of thecallandread_stateAPIs.This is basically a porting of https://github.com/dfinity/agent-rs/pull/672/files#diff-463e496396a1c352674f5d6dfe40ccb2527b1460c1e38662ecd3010743cda49cR977-R1000.
How Has This Been Tested?
Since we are not supporting the new API versions, all the certificate checks should fall into the
lookupCanisterRangesFallbackcase, so all existing tests should still work.Checklist: