From e7628ea3b20505b0284f9c77960f88eb6d1a32d1 Mon Sep 17 00:00:00 2001
From: Kyle Peacock <kylpeacock@gmail.com>
Date: Wed, 23 Aug 2023 11:31:47 -0700
Subject: [PATCH] fix: default host logic fixed and tests added

---
 docs/generated/changelog.html              |  2 +-
 packages/agent/src/agent/http/http.test.ts | 34 ++++++++++++++++++++--
 packages/agent/src/agent/http/index.ts     | 12 +++++++-
 3 files changed, 44 insertions(+), 4 deletions(-)

diff --git a/docs/generated/changelog.html b/docs/generated/changelog.html
index 96ea3dda9..0aec23b41 100644
--- a/docs/generated/changelog.html
+++ b/docs/generated/changelog.html
@@ -12,7 +12,7 @@ <h1>Agent-JS Changelog</h1>
     <section>
       <h2>Version x.x.x</h2>
       <ul>
-        <li></li>
+        <li>fix: default host logic fixed and tests added</li>
       </ul>
       <h2>Version 0.19.0</h2>
       <ul>
diff --git a/packages/agent/src/agent/http/http.test.ts b/packages/agent/src/agent/http/http.test.ts
index 74f93a1f7..3adcda2e1 100644
--- a/packages/agent/src/agent/http/http.test.ts
+++ b/packages/agent/src/agent/http/http.test.ts
@@ -13,7 +13,7 @@ import { Principal } from '@dfinity/principal';
 import { requestIdOf } from '../../request_id';
 
 import { JSDOM } from 'jsdom';
-import { AnonymousIdentity, SignIdentity, SubmitResponse, UpdateCallRejectedError } from '../..';
+import { AnonymousIdentity, SignIdentity } from '../..';
 import { Ed25519KeyIdentity } from '../../../../identity/src/identity/ed25519';
 import { toHexString } from '../../../../identity/src/buffer';
 import { AgentError } from '../../errors';
@@ -39,7 +39,12 @@ const originalWindow = global.window;
 const originalFetch = global.fetch;
 beforeEach(() => {
   global.Date.now = jest.fn(() => new Date(NANOSECONDS_PER_MILLISECONDS).getTime());
-  global.window = originalWindow;
+  Object.assign(global, 'window', {
+    value: {
+      originalWindow,
+    },
+    writable: true,
+  });
   global.fetch = originalFetch;
 });
 
@@ -754,3 +759,28 @@ test('should fetch with given call options and fetch options', async () => {
   expect(calls[0][1].reactNative).toStrictEqual({ textStreaming: true });
   expect(calls[1][1].reactNative.__nativeResponseType).toBe('base64');
 });
+
+describe('default host', () => {
+  it('should use a default host of icp-api.io', () => {
+    const agent = new HttpAgent({ fetch: jest.fn() });
+    window.location.hostname; //?
+    expect((agent as any)._host.hostname).toBe('icp-api.io');
+  });
+  it('should use a default of icp-api.io if location is not available', () => {
+    delete (global as any).window;
+    const agent = new HttpAgent({ fetch: jest.fn() });
+    expect((agent as any)._host.hostname).toBe('icp-api.io');
+  });
+  it('should use the existing host if the agent is used on a known hostname', () => {
+    const knownHosts = ['ic0.app', 'icp0.io', 'localhost', '127.0.0.1'];
+    for (const host of knownHosts) {
+      delete window.location;
+      window.location = {
+        hostname: host,
+        protocol: 'https:',
+      } as any;
+      const agent = new HttpAgent({ fetch: jest.fn(), host });
+      expect((agent as any)._host.hostname).toBe(host);
+    }
+  });
+});
diff --git a/packages/agent/src/agent/http/index.ts b/packages/agent/src/agent/http/index.ts
index 9cce96e1a..d1442f85b 100644
--- a/packages/agent/src/agent/http/index.ts
+++ b/packages/agent/src/agent/http/index.ts
@@ -210,7 +210,17 @@ export class HttpAgent implements Agent {
           'Could not infer host from window.location, defaulting to mainnet gateway of https://icp-api.io. Please provide a host to the HttpAgent constructor to avoid this warning.',
         );
       }
-      this._host = new URL(location + '');
+      // Mainnet and local will have the api route available
+      const knownHosts = ['ic0.app', 'icp0.io', 'localhost', '127.0.0.1'];
+      if (location && knownHosts.includes(location.hostname)) {
+        // If the user is on a boundary-node provided host, we can use the same host for the agent
+        this._host = new URL(location + '');
+      } else {
+        this._host = new URL('https://icp-api.io');
+        console.warn(
+          'Could not infer host from window.location, defaulting to mainnet gateway of https://icp-api.io. Please provide a host to the HttpAgent constructor to avoid this warning.',
+        );
+      }
     }
     // Default is 3, only set from option if greater or equal to 0
     this._retryTimes =