Skip to content

fix: adds npm run build to publish script #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 13, 2024
Merged

fix: adds npm run build to publish script #845

merged 2 commits into from
Feb 13, 2024

Conversation

@krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Feb 13, 2024 •
edited
Loading

Description

Fixes an issue that we encountered during the last agent-js publish workflow, where the packages weren't built before publishing

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from a team as a code owner February 13, 2024 00:17
@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2024 •
edited
Loading

size-limit report 📦

Path Size
@dfinity/agent 101.1 KB (0%)
@dfinity/candid 13.61 KB (0%)
@dfinity/principal 5.04 KB (0%)
@dfinity/auth-client 91.73 KB (0%)
@dfinity/assets 92.87 KB (0%)
@dfinity/identity 89.05 KB (0%)
@dfinity/identity-secp256k1 264.33 KB (0%)

@krpeacock krpeacock enabled auto-merge (squash) February 13, 2024 17:08
@krpeacock krpeacock merged commit da8edb4 into main Feb 13, 2024
@krpeacock krpeacock deleted the kai/publish-build-command branch February 13, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@krpeacock