Skip to content

fix: passing request correctly during pollForResponse Processing status #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 23, 2024
Merged

fix: passing request correctly during pollForResponse Processing status #909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
889dcb6
fix: passing request correctly during pollForResponse Processing status
krpeacock Jul 23, 2024
3e68a89
Merge branch 'main' into kai/pollforresponse-bug
krpeacock Aug 23, 2024
7799c71
Merge branch 'main' into kai/pollforresponse-bug
krpeacock Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@

### Changed

- fix: passing `request` correctly during pollForResponse `Processing` status
- credit: [Senior Joinu](https://forum.dfinity.org/t/timestamp-failed-to-pass-the-watermark-after-retrying-the-configured-3-times/29180/11?)
- ci: removing headless browser tests pending a rewrite
- ci: changing token for creating release

Expand Down
2 changes: 1 addition & 1 deletion packages/agent/src/polling/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export async function pollForResponse(
case RequestStatusResponseStatus.Processing:
// Execute the polling strategy, then retry.
await strategy(canisterId, requestId, status);
return pollForResponse(agent, canisterId, requestId, strategy, currentRequest);
return pollForResponse(agent, canisterId, requestId, strategy, currentRequest, blsVerify);

case RequestStatusResponseStatus.Rejected: {
const rejectCode = new Uint8Array(
Expand Down