Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/request and response logs #721

Merged
merged 11 commits into from Apr 19, 2022
Merged

Feat/request and response logs #721

merged 11 commits into from Apr 19, 2022

Conversation

mstrasinskis
Copy link
Contributor

Motivation

To get more information from user side the log messages were added.

Changes

  • added logWithTimestamp
  • requests log their status with some details (e.g. neuronId)
    • to not disturb people with raw data in dev.console all IDs are converted into hashes (see hashCode)
  • to be sure that the app doesn't try to vote w/ duplications registerVotes does extra step to be sure neuronIds are unique with extra console.error if not.
  • voting error handling was updated to rely on all rejected requests (not only with human readable message

Tests

  • queryAndUpdate should log

Notes

  • Probably it's better to replace hashCode with something random based...

Screenshots

Untitled.mov

@mstrasinskis mstrasinskis requested review from peterpeterparker and a user April 19, 2022 16:33
peterpeterparker
peterpeterparker approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@mstrasinskis mstrasinskis merged commit 93166d1 into main Apr 19, 2022
@mstrasinskis mstrasinskis deleted the feat/request-and-response-logs branch April 19, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterpeterparker peterpeterparker peterpeterparker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mstrasinskis @peterpeterparker