Add missing Motoko keywords and remove extra Swift keywords #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dear @rvanasa, In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA1. If you decide to agree with it, please visit this issue and read the instructions there. — The DFINITY Foundation Footnotes
|
|
cc @kritzcreek |
kritzcreek
approved these changes
May 24, 2022
ggreif
approved these changes
May 25, 2022
|
Thanks indeed! |
ggreif
pushed a commit
that referenced
this pull request
Jun 12, 2022
Continuation of #23. The current TextMate language specification is almost directly based on Swift, so this PR fixes most of the remaining syntax highlighting and namespace issues. This PR also adds a minimal `.vscodeignore` file as encouraged by the `vsce package` command. Works as expected on Ubuntu (WSL) using the latest version of VSCode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
flexible,stable,ignore, andlabelkeywords while removing extraneous Swift keywords such asopen,get,set,operator, etc.Syntax highlighting should now be consistent with the documentation.
Fixes #15
Fixes #19