FR: Icons for custom assets

[m-terlinde]

Hey guys,

first of all let me say "thank you" for your work! I think IRIS will become a great and handy tool and I appreciate the fresh start.

I have a feature request: custom asset types will get an empty icon on the Graph. On the creation of the custom asset type, I want to upload an icon for it.

As a side note: is it on purpose, that the type "Windows - DC" does not have an icon as well?

Thanks once again,
Matthias

[whikernel]

Hi @m-terlinde

Thanks for your kind feedback and the issue!
So the unknown/custom assets type were indeed missing an icon. This was fixed in e8950f6 and will be commited in the next minor version. There will be an interrogation mark when the asset type is not recongnised.

Indeed it would be great to be able to upload an image for custom asset types. The way it's working for now is by pattern. For instance if your asset type contains computer and also windows then the windows_computer.png is picked. If the asset is compromised then the red version is chosen. It's really not an ideal system. It will be changed, but probably not in the next minor version.

And for the DC, yes indeed, there's an entry for domain controller but not DC. We'll update it, so at least the default asset types have proper icons !

[m-terlinde]

Thanks a lot, sounds good.
The heuristic is better than no icon, so probs for this solution.