docker-compose cleanup#213
Merged
Merged
Conversation
whikernel
reviewed
Apr 18, 2023
whikernel
left a comment
whikernel
left a comment
Contributor
There was a problem hiding this comment.
Hi @juadde
Indeed we can clean up most of them. I would still like to keep the DB and the WebApp because it helps a lot to troubleshoot when people have issues. Otherwise we need to split the dockerfile in multiple dockerfiles and use one for debug, but it slightly complexify the setup.
Contributor
Author
|
Sure, I can understand, what would you think of this ? |
Contributor
|
Looks good to me! 👍 We'll also add a note in the documentation |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In docker-compose, there is no need to export ports (but maybe it was for debugging purposes?), because as long as the containers are in the same network they can communicate (bridge is the default network driver, so we could remove those lines too).
Would you be OK with this cleanup? (IRIS seems OK after the change)